-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{chem,lib}[intel/2018b] GlobalArrays v5.7, OpenMolcas v18.09 #7699
{chem,lib}[intel/2018b] GlobalArrays v5.7, OpenMolcas v18.09 #7699
Conversation
…cas-18.09-intel-2018b-ethernet.eb
Did you specifically need a ethernet version? Seems like some version of --with-mpi* would be more useful? I tried building GA a while back, but I used it's CMake component. I ended up with a libcomex.a library, without specifying any particular flags for this. |
just tested, without any armci related options, it defaults to this
and effectively there's a libcomex.a built that provides an interface with the used MPI library? dropping the interconnect specification at the GA level ? |
@Micket I upgraded the ebs by using |
@Micket I created the patches for GA based on the pull requests upstream you mentioned, I added another small patch for OpenMolcas, as one script triggered during the installation, will try to force a copy of the The build of both things goes on fine, and a small test job i was given runs fine. |
i don't get why i got only this time the error during Travis Checks
despite the dep was always there before. fixed in latest commit. |
@arielzn We enhance the checks done in Travis from time to time, and for some things we only enforce them in easyconfigs being added/touched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielzn Please add a short description + mention author or upstream reference to where patch was obtained from at the top of every patch (and keep in mind that you'll need to update the checksums for the patch files accordingly)
@Micket that was what you requested , right ? |
@arielzn I got really busy last week. If you could do a |
some bad news, when enabling those options for GA, I get errors when building OpenMolcas afterwards (GA finished fine). The OpenMolcas errors are as these:
If I remove those NWChem options and rebuild GA, OpenMolcas builds fine. any idea of what could be causing that? |
The option to blame seems to be When using that is required to build something else as prereq ? I can't find detailed info about that PeIGS library. |
@arielzn I looked into it, and it seems the parallel eig function in GlobalArrays expects the user to link in external symbols. NWChem implements these functions; GA should have kept this addition as a separate library, so that normal users can link to just what they need, but.. they didn't. Pretty horrid design choices all around here I would say. Our options are
Option 1 would mean that there are incompatible.. but, perhaps that's just what we need. It would also allow users to pick. Still though, very annoying, as this could have been so very easily avoided by GA. |
Some info about I'm not sure then if we can have a GA version compatible with NWChem and OpenMolcas at the same time. |
Just saw your message after my last comment. We could try 2. I'm not sure how these things were handled in other cases, if something equivalent happened before. |
I think we could with if OpenMolcas statically linked. It's never going to call It doesn't really build anything different; it just replaces the functionality with a dummy function (with no external deps) if you don't enable it: Question is, what is the least ugly solution? Probably just having 2 GA's and add |
probably that will be the most explicit and cleaner solution, in case some other package is going ever to be built against GA |
Yes. Just drop the extra flags, I will be making a new PR for 2019a with a -peigs version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @arielzn |
Going in, thanks @arielzn! |
(created using
eb --new-pr
)